python-fire icon indicating copy to clipboard operation
python-fire copied to clipboard

Fix #229, #293: Modify parser.py to re-insert quotes correctly

Open stephenvincent27 opened this issue 4 years ago • 5 comments

Passes: parser_test.py parser_fuzz_test.py (?) main_test.py

We are not Python programmers primarily, so do let us know if there are fragments of code that can be rewritten in Python to make it more readable. Other than that, this code conforms faithfully to the flowchart we sent over earlier.

stephenvincent27 avatar Jan 13 '21 08:01 stephenvincent27

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Jan 13 '21 08:01 google-cla[bot]

@googlebot I signed it!

stephenvincent27 avatar Jan 13 '21 08:01 stephenvincent27

Thank you for the PR! I will let you know once I have looked through it more closely.

You mentioned in our discussion on #229 that you had some test cases. Could you add those to this PR?

dbieber avatar Jan 26 '21 16:01 dbieber

Hello @dbieber! Really sorry for the super-long hiatus. I've added relevant tests (some of which we'd discussed earlier), feel free to suggest additions/modifications to them.

stephenvincent27 avatar Sep 24 '21 09:09 stephenvincent27

Hello again. Thanks for adding the tests!

dbieber avatar Sep 24 '21 14:09 dbieber