python-fire
python-fire copied to clipboard
Fix #229, #293: Modify parser.py to re-insert quotes correctly
Passes:
parser_test.py
parser_fuzz_test.py (?)
main_test.py
We are not Python programmers primarily, so do let us know if there are fragments of code that can be rewritten in Python to make it more readable. Other than that, this code conforms faithfully to the flowchart we sent over earlier.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
Thank you for the PR! I will let you know once I have looked through it more closely.
You mentioned in our discussion on #229 that you had some test cases. Could you add those to this PR?
Hello @dbieber! Really sorry for the super-long hiatus. I've added relevant tests (some of which we'd discussed earlier), feel free to suggest additions/modifications to them.
Hello again. Thanks for adding the tests!