python-fire icon indicating copy to clipboard operation
python-fire copied to clipboard

Update: unittest extension for python 3.x

Open AIweimd opened this issue 5 years ago • 3 comments

Hi, The mock object library has been integrated into the unittest module in python3.x, so I try to add extention like this.

try:

import mock  # python 2.x

except ModuleNotFoundError:

from unittest import mock  # python 3.x

Thanks for watching.

AIweimd avatar Jun 09 '20 03:06 AIweimd

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Jun 09 '20 03:06 googlebot

Thanks for the PR!

If I understand correctly, mock as a package from pypi continues to work in Python 3, and this change just allows us to drop the dependency on mock for testing purposes for Python 3.

Can you confirm I'm understanding correctly?

Could you also sign the CLA, please?

dbieber avatar Dec 16 '20 20:12 dbieber