osv-scanner
osv-scanner copied to clipboard
chore: explicitly allow linting errors from `package-comments`
By default golangci-lint ignores output from package-comments unless you explicitly allow it, even if you're already explicitly enabling the underlying rule, as they consider it too noisy for most codebases
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.51%. Comparing base (
95d840a) to head (9cb7314). Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #1720 +/- ##
==========================================
+ Coverage 67.50% 67.51% +0.01%
==========================================
Files 172 172
Lines 16242 16242
==========================================
+ Hits 10964 10966 +2
+ Misses 4603 4601 -2
Partials 675 675
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
I think the linter is doing its work - we need to add comments to these packages.
@cuixq yup that's the next step - I'm going to be working on that in the background, but its currently a low priority
This pull request has not had any activity for 60 days and will be automatically closed in two weeks
not stale, just have not gotten around to it yet 😅