osv-scanner icon indicating copy to clipboard operation
osv-scanner copied to clipboard

chore: explicitly allow linting errors from `package-comments`

Open G-Rath opened this issue 8 months ago • 3 comments

By default golangci-lint ignores output from package-comments unless you explicitly allow it, even if you're already explicitly enabling the underlying rule, as they consider it too noisy for most codebases

G-Rath avatar Mar 18 '25 03:03 G-Rath

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.51%. Comparing base (95d840a) to head (9cb7314). Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1720      +/-   ##
==========================================
+ Coverage   67.50%   67.51%   +0.01%     
==========================================
  Files         172      172              
  Lines       16242    16242              
==========================================
+ Hits        10964    10966       +2     
+ Misses       4603     4601       -2     
  Partials      675      675              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Mar 18 '25 03:03 codecov-commenter

I think the linter is doing its work - we need to add comments to these packages.

cuixq avatar Apr 02 '25 23:04 cuixq

@cuixq yup that's the next step - I'm going to be working on that in the background, but its currently a low priority

G-Rath avatar Apr 03 '25 20:04 G-Rath

This pull request has not had any activity for 60 days and will be automatically closed in two weeks

github-actions[bot] avatar Jun 02 '25 21:06 github-actions[bot]

not stale, just have not gotten around to it yet 😅

G-Rath avatar Jun 02 '25 21:06 G-Rath