open-location-code icon indicating copy to clipboard operation
open-location-code copied to clipboard

Published 20 hours ago • verified publisher icon google

C implementation: Fix compiler warnings

Open fulldecent opened this issue 11 months ago • 3 comments

The C implementation currently has compiler warnings.

https://github.com/google/open-location-code/actions/runs/12468691641/job/34800362797

These are related to non-standard extensions implemented in our C implementation instead of what our specification requires.

fulldecent avatar Dec 23 '24 15:12 fulldecent

Fixed at https://github.com/google/open-location-code/pull/651

That PR

  • Fixes C build warnings from code issue
  • Fixes C build warnings from Bazel issues

and results in no C build warnings

fulldecent avatar Dec 23 '24 15:12 fulldecent

What are the warnings you want to address? Is it just?

warning: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Wsign-compare]

drinckes avatar Dec 24 '24 08:12 drinckes

I wanted it to build clean with no warnings or errors as reported in GitHub actions

fulldecent avatar Dec 24 '24 13:12 fulldecent