oboe icon indicating copy to clipboard operation
oboe copied to clipboard

Support landscape mode in OboeTester

Open philburk opened this issue 4 years ago • 2 comments
trafficstars

This will help it work better on Android TV. Currently it locks to portrait mode in the AndroidManifest.xml.

philburk avatar Feb 25 '21 00:02 philburk

The Stadia Team has requested this.

We should also test it on low-res phones.

philburk avatar Jul 30 '21 00:07 philburk

It seems like the main challenge in this is how to fit everything in landscape mode.

Here is an image of OboeTester in portrait mode.

image

In landscape mode, all these components clearly won't fit if we leave this as is.

I have two proposals on how to solve this problem.

  1. For all the settings, try to combine rows as possible. For example, API and Device are combined on the same row image
  2. Use two columns to split the work into two columns image

Option 1 requires each small component to be changed to split them into multiple rows. Like audio_devices.xml. However, each specific test like activity_test_disconnect.xml can stay the same in most cases. Option 2 does the reverse and lets each small component stay the same while each individual test is changed so the columns are fine.

Both options are a fair amount of work.

robertwu1 avatar Jul 30 '21 16:07 robertwu1