material-design-lite icon indicating copy to clipboard operation
material-design-lite copied to clipboard

After forking & cloning the google / material-design-lite, I cannot get the local project to work

Open charlesr1971 opened this issue 4 years ago • 6 comments

I would like to contribute by creating a dark mode for mdl lite

After forking & cloning the google / material-design-lite, I then use:

npm install

I then install:

npm install -g gulp-cli
npm install -g babel-register

But, when I go:

gulp serve

I get:

Requiring external module babel-register
ReferenceError: primordials is not defined

I am using Windows 10...

charlesr1971 avatar Feb 14 '21 18:02 charlesr1971

Material Design Lite is no longer being maintained. Please consider a move to the direct successor, Material Components for Web.

Garbee avatar Mar 20 '21 23:03 Garbee

For all new sites, I am using Angular Material, but I have a lot of legacy websites that use mdl lite. It is a real shame there is no dark theme?

charlesr1971 avatar Mar 21 '21 01:03 charlesr1971

For MDL, no dark theme. MCW got it as that was a part of MDL 2.x efforts that evolved into MCW.

Garbee avatar Mar 21 '21 02:03 Garbee

I understand. But so many people downloaded material design lite. It is totally impossible for us to upgrade on legacy websites that are still under development. On one of my websites, there are thousands of references to ‘mdl’.

If someone from the original team could give me some pointers on how best I could add a ‘dark’ theme? I have already forked the repo. I am happy to do the work. It is the only big issue, still outstanding. Many of the other components have been built by third parties, like ‘mdl-select-field’ and ‘mdl-stepper’.

Thanks...

charlesr1971 avatar Mar 21 '21 09:03 charlesr1971

Applying a dark theme is very involved. There isn't some straightforward way to "just do it" (otherwise, we would have.)

Best thing you can do is target what is needed and change the colors according to the MD specs for dark designs. Just make it the last stylesheet, it'll take effect.

Garbee avatar Mar 21 '21 09:03 Garbee

OK. Thanks for those pointers. I will give it a go...

charlesr1971 avatar Mar 21 '21 09:03 charlesr1971