keytransparency icon indicating copy to clipboard operation
keytransparency copied to clipboard

Published 20 hours ago • verified publisher icon google

Build webpage for KT monitor

Open gdbelvin opened this issue 6 years ago • 8 comments

The KT monitor webpage in core/monitor is currently bare bones and could use an update to be more user friendly.

gdbelvin avatar Jan 28 '19 13:01 gdbelvin

Hm, i can't find it in core/monitor, or do i miss something? BYTW, i will take this one for sure, just need some introduction and details.

Zyqsempai avatar Jan 28 '19 14:01 Zyqsempai

Here's the URL of the main package: https://github.com/google/keytransparency/blob/master/cmd/keytransparency-monitor/main.go

The objective is to show a list of Key Transparency revisions, and whether the monitor was able to fully verify them. I believe the current implementation runs the verification logic and stores the results.

gdbelvin avatar Jan 28 '19 14:01 gdbelvin

Any idea why i get ERROR: for log-server Cannot start service log-server: OCI runtime create failed: container_linux.go:344: starting container process caused "exec: \"/go/bin/trillian_log_server\": stat /go/bin/trillian_log_server: no such file or directory": unknown on docker-compose up -d ?

Zyqsempai avatar Jan 28 '19 22:01 Zyqsempai

So related to monitor webpage, as far as i can see from our http api, we provide only to endpoints for monitor: / /metrics Metrics is just ling to the prometheus info, and / consist of two endpoints: getState and getStateByRevision As far as i get you want to prvide also a list of revisions? Sorry, for dumb questions, not so familiar with that part of project, and that fact that I am not able to build and run it properly, not play's on my side ;)

Zyqsempai avatar Jan 28 '19 22:01 Zyqsempai

Your first error is a bug that #1169 fixes.

at / we provide some json endpoints, yes, but I think we also want to have a home page that returns interesting stats in HTML table form:

  • Revision, Timestamp, Number of changes, and whether it was verified correctly.

Just discovered this issue is a duplicate of #803 and that #804 contains an (old) initial stab at it.

gdbelvin avatar Feb 01 '19 15:02 gdbelvin

So, what should we do? You want me to try to continue working on https://github.com/google/keytransparency/pull/804 ? I am not the frontend specialist)) but it seems like almost finished)

Zyqsempai avatar Feb 02 '19 15:02 Zyqsempai

Why don't I finish #804 since I have a bit more context on it. Do you want to try #643 or any of the other HelpWanted issues?

gdbelvin avatar Feb 04 '19 10:02 gdbelvin

Sure, i'l take this one https://github.com/google/keytransparency/issues/1178

Zyqsempai avatar Feb 04 '19 11:02 Zyqsempai