jax icon indicating copy to clipboard operation
jax copied to clipboard

Determine symmetric linear op fro CG from abstract output dtype

Open Joshuaalbert opened this issue 1 year ago • 1 comments

Address #23403

Joshuaalbert avatar Sep 06 '24 23:09 Joshuaalbert

@jakevdp want to review this?

Joshuaalbert avatar Sep 07 '24 11:09 Joshuaalbert

Lint is failing due to an unused import

jakevdp avatar Sep 16 '24 19:09 jakevdp

The CI failures look to be related to this change

jakevdp avatar Sep 16 '24 21:09 jakevdp

There's some issue with github actions currently, so for some reason I can't trigger the tests. I'd suggest running them locally via pytest -n auto tests to see if there's any remaining issues

jakevdp avatar Sep 16 '24 23:09 jakevdp

I don't see an easy way to squash since I've already created the PR. @jakevdp

Joshuaalbert avatar Sep 24 '24 07:09 Joshuaalbert

I squashed on another PR. https://github.com/Joshuaalbert/jax/tree/update-cg

Joshuaalbert avatar Sep 24 '24 08:09 Joshuaalbert

You can squash the commits and force-push to the branch this PR was made from, and it will update here. Please let me know if you'd like me to walk you through it – thanks!

jakevdp avatar Sep 24 '24 12:09 jakevdp

@jakevdp figured it out. There was some issue with it dropping my branch after interactive rebase, which made force push fail, but found that git rebase --continue solved it.

Joshuaalbert avatar Sep 25 '24 13:09 Joshuaalbert

Thanks - but it looks like there are now conflicts with respect to the main branch. Can you rebase against the updated main branch, and then make sure your branch only contains one commit on top of main? Thanks!

jakevdp avatar Sep 25 '24 16:09 jakevdp

@jakevdp There you go

Joshuaalbert avatar Sep 30 '24 08:09 Joshuaalbert

Something went wrong here: you now have almost 100 commits on your branch. It looks like you probably merged an updated main branch, and then rebased against an older version of the main branch.

Can you please rebase against the most recent main branch?

jakevdp avatar Sep 30 '24 11:09 jakevdp

Probably because I forked and then modified the main branch. I'll see what I can do with this mess.

Joshuaalbert avatar Oct 01 '24 09:10 Joshuaalbert

Mess resolved?

Joshuaalbert avatar Oct 01 '24 09:10 Joshuaalbert

@jakevdp sorry was off, but remembered to come back to finish it off. Tests added

Joshuaalbert avatar Oct 25 '24 14:10 Joshuaalbert

@jakevdp back to you

Joshuaalbert avatar Nov 06 '24 12:11 Joshuaalbert

@jakevdp

Joshuaalbert avatar Nov 14 '24 10:11 Joshuaalbert

@jakevdp

Joshuaalbert avatar Nov 16 '24 13:11 Joshuaalbert