gvisor icon indicating copy to clipboard operation
gvisor copied to clipboard
verified publisher icon google

Implement renameat2(2) for real

Open pkit opened this issue 3 years ago • 3 comments

fixes #7895

pkit avatar Aug 16 '22 16:08 pkit

Tests added. Should be ok. @hbhasker @avagin

pkit avatar Aug 17 '22 13:08 pkit

pls add more details in the commit message. Right now, it is not clear what this change implements. It seems that this change adds the support of the RENAME_EXCHANGE flag for gofer file systems. What is about overlay and tmpfs?

avagin avatar Aug 19 '22 19:08 avagin

@avagin I can add to other fs too, if that's needed. I can also discuss adding RENAME_WHITEOUT to all of them, if needed, but it looks like MKNOD capability is prohibited anyway?

pkit avatar Aug 20 '22 11:08 pkit

Sorry for the delay, will rework it and resubmit with the proposed changes

pkit avatar Sep 30 '22 11:09 pkit

@ayushr2 I can add tmpfs in another PR, is it ok? I'm pretty much ready with a new code for gofer that fixes all the comments.

pkit avatar Dec 08 '22 15:12 pkit

@pkit Yes adding tmpfs support should be a separate PR.

Feel free to push your new changes for review.

ayushr2 avatar Dec 08 '22 20:12 ayushr2

@ayushr2 pushed new version Has some preparation for other fs tests in test cases

pkit avatar Dec 08 '22 21:12 pkit

A friendly reminder that this PR had no activity for 120 days.

github-actions[bot] avatar Sep 13 '23 00:09 github-actions[bot]

This PR has been closed due to lack of activity.

github-actions[bot] avatar Dec 13 '23 00:12 github-actions[bot]