gvisor icon indicating copy to clipboard operation
gvisor copied to clipboard
verified publisher icon google

Implement renameat2(2) for real

Open pkit opened this issue 3 years ago • 1 comments

Description

Right now renameat2 is not really implemented as only the RENAME_NOREPLACE flag works and it's implemented through renameat at the lowest fs level. I don't see any problem implementing all other flags using the lisafs interface.

I'm particularly interested in RENAME_EXCHANGE though. As right now renameat2(...., RENAME_EXCHANGE) is spitting EINVAL

Is this feature related to a specific bug?

https://github.com/google/gvisor/issues/263

Do you have a specific solution in mind?

I have created a PoC support for RENAME_EXCHANGE and will post it shortly as a PR.

pkit avatar Aug 16 '22 15:08 pkit

Okay it looks like RENAME_WHITEOUT is out of the question right now, till the bind mount/CLONE_NEWNS is implemented

pkit avatar Aug 17 '22 15:08 pkit

A friendly reminder that this issue had no activity for 120 days.

github-actions[bot] avatar Sep 13 '23 00:09 github-actions[bot]