googletest

googletest copied to clipboard

Properly export GTEST_HAS_PTHREAD compile definition with CMake

3

Fix #3692 ```diff --- /lib/cmake/GTest/GTestTargets.cmake +++ /lib/cmake/GTest/GTestTargets.cmake @@ -54,7 +54,6 @@ add_library(GTest::gtest STATIC IMPORTED) set_target_properties(GTest::gtest PROPERTIES + INTERFACE_COMPILE_DEFINITIONS "GTEST_HAS_PTHREAD=0" INTERFACE_COMPILE_FEATURES "cxx_std_11" INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include" INTERFACE_LINK_LIBRARIES "Threads::Threads" @@ -65,7 +64,6 @@ add_library(GTest::gtest_main...

dalg24

Infinite recursion leading to crash when death tests are disabled

1

**Describe the bug** https://github.com/google/googletest/commit/e5686bb18b52dc29312a7b79c3d6ca2c826c31ed from https://github.com/google/googletest/pull/3090 introduced a change where `original_working_dir_` is only set when `GTEST_HAS_DEATH_TEST` are enabled. This makes the assumption that death tests being disabled is synonymous to...

gaspardpetit

boost::optional<T&> as function argument not supported if T is non-printable

3

**Describe the bug** Fails to compile the following code: ```C++ class SomeClass { }; class Tester { public: virtual void Foo(boost::optional const& val) = 0; virtual ~Tester() = default; };...

zefir-o

The strange 'TEST EXECUTE FAILED' only on iOS

2

In `license_test.cpp` only one test. And it looks lie this: ```cpp TEST(Test, License) { #if !defined(WITH_LICENSE) GTEST_SKIP(); #else checkLicense(); #endif } ``` **In case, if the macro `WITH_LICENSE` is not...

SergeyJames

Removing the 'd' debug postfix broke the CMake workflow

3

**Describe the bug** Removing the 'd' suffix for debug libs broke the CMake workflow. The `FindGTest.cmake` of cmake expects the debug libraries of gtest to have this suffix : https://github.com/Kitware/CMake/blob/master/Modules/FindGTest.cmake#L248...

stilllman

Warnings with nvc++ as the compiler

3

**Describe the bug** The following warnings were observed when building googletest: ``` [ 12%] Building CXX object googletest/CMakeFiles/gtest.dir/src/gtest-all.cc.o "/ascldap/users/crtrott/Software/googletest/googletest/src/gtest-internal-inl.h", line 636: warning: unknown attribute "optimize" GTEST_NO_INLINE_ GTEST_NO_TAIL_CALL_; ^ "/ascldap/users/crtrott/Software/googletest/googletest/src/gtest.cc", line...

crtrott

Mock object leaks after EXPECT_CALL and EXPECT_EXIT with -1

4

**Describe the bug** After I call `EXPECT_CALL` on a mock object and then call a function that returns -1 from `EXPECT_EXIT` I get a message about an object that should...

JDuchniewicz

support std::string_view for comparisons

1

Hello, The existing macros (or rather their helpers) still expect C-style strings, which means you will have to make sure your string-types can offer zero-terminated strings. and often manually request...

nolange

`MakeFileName()` creates hidden file in case `base_name` is empty.

3

**Describe the bug** The current version of function `MakeFIleName()` in `FilePath` API doesn't check if the `base_name` is empty or not. In case the `number` passed to the function is...

joshiayush

Xml Generation from Google test does not show skipped test cases count in tag testsuites

2

I am using gtest version `V1.11.0` I have disabled few tests and Skipped few tests. This is working fine and i can see the tests being disabled and skipped in...

satishsingh0077