googletest issues

Advanced googletest documentation's "Assertion Placement" section missing a compact workaround on non-void contexts

### Describe the issue A Googletest assertion requires the calling method to return `void`. The [advanced documentation on that topic](https://google.github.io/googletest/advanced.html#assertion-placement) suggests refactoring the method if required. A more straightforward way...

rsarrazin2

UBSan: Invalid vptr when compiling with no-rtti

4

### Describe the issue ``` src/googletest/src/gtest.cc:2727:32: runtime error: member call on address 0x55ef35a2f690 which does not point to an object of type 'TestFactoryBase' 0x55ef35a2f690: note: object has invalid vptr 00...

chriselrod

CMake Error : set_target_properties called with incorrect number of arguments.

8

**Describe the bug** > root@root:/googletest/googletest/build# cmake .. -- The CXX compiler identification is GNU 7.5.0 -- The C compiler identification is GNU 7.5.0 -- Check for working CXX compiler: /usr/bin/c++...

vijaypanchal

bug

[Bug]: Internal section links in docs (markdown) do not work

1

### Describe the issue The internal section links (by heading ID) are not working (at least not in GitHub's markdown renderer). Example: https://github.com/google/googletest/blob/5ab508a01f9eb089207ee87fd547d290da39d015/docs/reference/assertions.md?plain=1#L159-L160 contains the link for this section: https://github.com/google/googletest/blob/5ab508a01f9eb089207ee87fd547d290da39d015/docs/reference/assertions.md?plain=1#L261...

kkaja123

Fix typos found by codespell

SunBlack

[Bug]: valgrind reports still reachable memory leaks when StrictMock or NiceMock are used

1

### Describe the issue Valgrind reports still reachable memory leaks when StrictMock or NiceMock are used. This didn't happen in gtest/gmock 1.11.0. ### Steps to reproduce the problem - Save...

bitrunner

Please fix failing tests (last passing commit was from 15 Oct 2022)

### Describe the issue Last revision showing green checkmark is from 15 Oct 2022 ### Steps to reproduce the problem Simply open the commits and look at the red "X"'s...

tellypresence

Max: Change to MaxValue

1

Some codebases still feature macroses such as Max(), which clash with gtrst-internal.h's Max() function. This change proposes that we name it as MaxValue().

serkazi