googletest icon indicating copy to clipboard operation
googletest copied to clipboard

ci: Test cmake_minimum_required

Open juan-lunarg opened this issue 2 years ago • 1 comments
trafficstars

Ensures project configures with 3.13 since it's very easy to write code that doesn't respect the minimum.

juan-lunarg avatar Jun 21 '23 18:06 juan-lunarg

As maintainers, we do not use GitHub actions CI. Instead, we have a proprietary workflow that runs the scripts in https://github.com/google/googletest/tree/main/ci. Our existing GHA are purely maintained by the open-source community.

Despite that, sometimes users believe GoogleTest is broken because GHA is broken, even though our internal workflows are green. Can we make the CMake CI as similar as possible to the internally used script? https://github.com/google/googletest/blob/ec4fed93217bc2830959bb8e86798c1d86956949/ci/linux-presubmit.sh#L45

dinord avatar Jun 22 '23 15:06 dinord

Closing this PR since I wasn't aware of the internal CI beforehand and am not sure how much contributing this would add to the project.

juan-lunarg avatar Jun 22 '23 19:06 juan-lunarg