googletest icon indicating copy to clipboard operation
googletest copied to clipboard

Add back support for platformio

Open ciband opened this issue 2 years ago • 3 comments
trafficstars

The version of googletest available to the Platformio framework is stale due to the removal of the library.json file from the googletest repo. To continue to support this community, it would be nice if we could add this file back.

ciband avatar Jun 01 '23 14:06 ciband

Do you have thoughts on how this can be kept up to date/tested? We do not have any experience with platformio and are not well-poised to maintain this. Is it critical that this file be in this git repository, or could it be maintained elsewhere?

asoffer avatar Jun 06 '23 03:06 asoffer

When the feature was first added, I also added CI tests that would at least compile the code to make sure it builds. Running the googletest unit tests would be impractical as we would need to run them on the target embedded hardware. I could certainly create a follow up PR to add those CI tests back.

If the library.json is stored in the repo, then the process for maintaining the library would be to update its version and any relevant changes to the include/exclude files, and then re-publish it with the PlatformIO framework.

Details on that here: https://docs.platformio.org/en/latest/librarymanager/creating.html#publishing

A future state could potentially automate this step as a part of the googletest CI/CD pipeline when you guys do releases.

If the file is not in this repo, then it would just have to be maintained locally and manually republished every time a googletest released.

ciband avatar Jun 06 '23 13:06 ciband

@asoffer, is there anything else you need for this PR, or are there any other questions I can answer?

ciband avatar Jun 20 '23 20:06 ciband