googletest icon indicating copy to clipboard operation
googletest copied to clipboard

Published 20 hours ago • verified publisher icon google

default to enable threading on Solaris, AIX and z/OS

Open pgroke-dt opened this issue 3 years ago • 6 comments

fix #3990

pgroke-dt avatar Aug 31 '22 13:08 pgroke-dt

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 31 '22 13:08 google-cla[bot]

@derekmauro Yes, sorry, I know. I asked the team that handles CLAs to sign it and enter my email address, and they told me they did. Then I created 2 PRs and the check failed. I talked to them again and they said there was some issue with Google's CLA manager and they already opened an issue for it. I don't have details but I'll ping them again tomorrow.

pgroke-dt avatar Sep 13 '22 19:09 pgroke-dt

For reference, the CLA issue is being discussed here: https://github.com/google/closure-compiler/pull/3988

pgroke-dt avatar Sep 14 '22 13:09 pgroke-dt

@derekmauro Took some time, but we finally figured the CLA stuff out.

pgroke-dt avatar Oct 04 '22 11:10 pgroke-dt

Hi. The CLA check is green now. There were failing tests, but I don't think they have anything to do with the changes in this PR - and I don't think I have permissions to (re-)run actions.

pgroke-dt avatar Nov 17 '22 12:11 pgroke-dt

@derekmauro I'd really like to proceed with this. Please let me know if there's something I need to do before this can be merged.

pgroke-dt avatar Jan 12 '23 12:01 pgroke-dt

@Hellothuy1 thanks for approving. I have resolved the conflicts.

pgroke-dt avatar May 02 '24 11:05 pgroke-dt