Deprecated implicit copy assignment/constructor

[omartijn]

I am having trouble getting googletest to compile. The problem is that many classes rely on a default move constructor while defining a copy or move assignment operator. This has been deprecated and the compiler rightly complains about this.

Since googletest also defines warnings as errors it means it just doesn't work.

[omartijn]

Example:

<path>/googletest/googlemock/src/gmock-spec-builders.cc:849:14: warning: definition of implicit copy assignment
      operator for 'Expectation' is deprecated because it has a user-declared destructor [-Wdeprecated]
Expectation::~Expectation() {}
             ^
<path>/googletest/googlemock/src/gmock-spec-builders.cc:858:24: note: in implicit copy assignment operator for
      'testing::Expectation' first required here
    *last_expectation_ = expectation;

[omartijn]

Anybody working on this? I'd make a PR to fix it, but I've tried it in the past and could not get past the cla-bot. I'd rather not repeat that experience.

[davidbolvansky]

Ping.

LLVM hit this issue with gtest too.

[sffc]

This is also affecting clients of google myanmar-tools: https://github.com/google/myanmar-tools/issues/42

[namazso]

This was fixed in https://github.com/google/googletest/pull/2815