go-tpm-tools icon indicating copy to clipboard operation
go-tpm-tools copied to clipboard

Published 20 hours ago • verified publisher icon google

Remove the x86 build/test from the CI.

Open qinkunbao opened this issue 1 year ago • 3 comments
trafficstars

Remove the x86 build/test from the CI from the CI for the following reasons.

  1. Our CVMs only support x86-64.
  2. Some dependency libraries (go-tdx-guest, go-sev-guest) are only tested with x86-64.
  3. go-tpm-tools releases only have x86-64.

qinkunbao avatar Sep 23 '24 19:09 qinkunbao

/gcbrun

JoshuaKrstic avatar Sep 23 '24 19:09 JoshuaKrstic

CVM is not the only platform this tool/lib can run. Majority features on gotpm cli and libs are not depending on go-tdx-guest/go-sev-guest Users may still want to build the binary on a 32 bit system.

jkl73 avatar Sep 23 '24 22:09 jkl73

So I think we probably should keep x86 build/test in CI, unless it's so broken and beyond fix.

jkl73 avatar Sep 24 '24 00:09 jkl73