go-github icon indicating copy to clipboard operation
go-github copied to clipboard

feat! Add `IssueListByOrgOptions` and update `ListByOrg` to use it

Open cpanato opened this issue 4 months ago • 9 comments

BREAKING CHANGE: ListByOrg now uses IssueListByOrgOptions instead of ListOptions.

we now can pass the Type of an issue to list issues for repo and orgs, so we can have a better filtering

https://docs.github.com/en/rest/issues/issues?apiVersion=2022-11-28#list-repository-issues

cpanato avatar Aug 20 '25 13:08 cpanato

cc @gmlewis

cpanato avatar Aug 20 '25 13:08 cpanato

Just FYI - I lost write access to this repo and this may cause unexpected delays for which I apologize. You can watch that other PR to check on the status.

gmlewis avatar Aug 20 '25 13:08 gmlewis

no worries, thanks for the heads up

cpanato avatar Aug 20 '25 13:08 cpanato

@gmlewis hello any updates on your permission?

cpanato avatar Sep 02 '25 11:09 cpanato

@gmlewis hello any updates on your permission?

No. You can watch #3689 to check on the status. I'm still attempting to get the attention of the owners of the repo to add me back as a maintainer.

gmlewis avatar Sep 02 '25 13:09 gmlewis

thanks, that is sad :(

cpanato avatar Sep 02 '25 13:09 cpanato

@cpanato - do you have time to resolve conflicts in this PR, or would you rather I do that?

gmlewis avatar Sep 22 '25 21:09 gmlewis

@gmlewis PTAL,rebased

cpanato avatar Sep 23 '25 13:09 cpanato

Codecov Report

:x: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 91.11%. Comparing base (ffc5df8) to head (99e98f3). :warning: Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
github/issues.go 83.33% 2 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3694      +/-   ##
==========================================
- Coverage   91.12%   91.11%   -0.02%     
==========================================
  Files         187      187              
  Lines       16640    16655      +15     
==========================================
+ Hits        15164    15176      +12     
- Misses       1291     1293       +2     
- Partials      185      186       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Sep 23 '25 16:09 codecov[bot]