go-cloud icon indicating copy to clipboard operation
go-cloud copied to clipboard

aws: lost "forcePathStyle" query parameter in AWS SDK V2

Open SebouChu opened this issue 1 year ago • 2 comments
trafficstars

Describe the bug

In 0.39.0, S3 URLs now use the V2 of the AWS SDK by default. Therefore, we lost the s3ForcePathStyle query parameter.

Based on their documentation, we might be able to reproduce the behavior of this parameter by allowing to set the HostnameImmutable endpoint option.

To Reproduce

Based on GCK documentation, having an S3URL with s3ForcePathStyle will crash. And removing the parameter might break operations like OpenBucket when endpoint host should not be changed.

Expected behavior

Operations should work with SDK V2, without the removed s3ForcePathStyle, and adding the support of a new parameter to set HostnameImmutable

Version

GCK 0.39.0

SebouChu avatar Aug 19 '24 08:08 SebouChu

See #3472 and https://github.com/google/go-cloud/pull/3473.

vangent avatar Aug 19 '24 15:08 vangent

thanks @vangent! I didn't see the closed issue about this, sorry :(

SebouChu avatar Aug 19 '24 16:08 SebouChu