glog icon indicating copy to clipboard operation
glog copied to clipboard

Comment describing SetVLOGLevel is not accurate

Open hari90 opened this issue 3 years ago • 2 comments

Currently the comment states the following:

// NOTE: To change the log level for VLOG(_IS_ON) sites
//	 that have already executed after/during InitGoogleLogging,
//	 one needs to supply the exact --vmodule pattern that applied to them.
//       (If no --vmodule pattern applied to them
//       the value of FLAGS_v will continue to control them.)

But https://github.com/google/glog/pull/650 added support for updating vmodule levels after vmodule level has been cached.

The comment should be

// NOTE: To change the log level for VLOG(_IS_ON) sites
//	 that matched a prior --vmodule pattern then the exact pattern has to be supplied again.
//       (If no --vmodule pattern applied to them before then the first matching pattern will start to control them.)

hari90 avatar Sep 07 '22 20:09 hari90

@romange Could you please verify the suggestion?

sergiud avatar Jan 05 '24 12:01 sergiud

@sergiud @romange I submitted https://github.com/google/glog/issues/1109 for this. Can you please review it?

hari90 avatar Jun 22 '24 16:06 hari90