glog icon indicating copy to clipboard operation
glog copied to clipboard

Add LOG_TO_SINK_IF and DLOG_TO_SINK

Open sukanth2705 opened this issue 1 year ago • 3 comments

Added LOG_TO_SINK_IF and DLOG_TO_SINK in logging.h

This PR closes #568

sukanth2705 avatar Jul 31 '24 08:07 sukanth2705

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jul 31 '24 08:07 google-cla[bot]

@sergiud Can u take a look?

sukanth2705 avatar Aug 06 '24 14:08 sukanth2705

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.03%. Comparing base (570c7e4) to head (18bbf15). Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1117      +/-   ##
==========================================
- Coverage   64.04%   64.03%   -0.02%     
==========================================
  Files          20       20              
  Lines        2578     2580       +2     
  Branches      898      908      +10     
==========================================
+ Hits         1651     1652       +1     
- Misses        662      663       +1     
  Partials      265      265              
Files Coverage Δ
src/glog/logging.h 83.60% <ø> (ø)

... and 1 file with indirect coverage changes

codecov-commenter avatar Aug 06 '24 16:08 codecov-commenter