glog icon indicating copy to clipboard operation
glog copied to clipboard

Fix comment NOTE about SetVLOGLevel

Open hari90 opened this issue 1 year ago • 2 comments

Fix the comment about SetVLOGLevel according to https://github.com/google/glog/pull/650 which added support for updating vmodule levels after vmodule level has been cached.

Fixes https://github.com/google/glog/issues/858

hari90 avatar Jun 21 '24 23:06 hari90

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.08%. Comparing base (45f99f5) to head (7e258ca).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1109      +/-   ##
==========================================
+ Coverage   63.57%   64.08%   +0.50%     
==========================================
  Files          20       20              
  Lines        2578     2578              
  Branches      894      906      +12     
==========================================
+ Hits         1639     1652      +13     
+ Misses        671      662       -9     
+ Partials      268      264       -4     

see 2 files with indirect coverage changes

codecov-commenter avatar Jun 22 '24 08:06 codecov-commenter

Thanks for the PR.

Doesn't it make more sense to supply the updated information in the user guide, for instance, by updating this section?

I have put a basic description of SetVLOGLevel in the doc and more detailed information in the .h file. Let me know if this looks good enough.

hari90 avatar Jun 24 '24 18:06 hari90