generative-ai-docs icon indicating copy to clipboard operation
generative-ai-docs copied to clipboard

Talking Character: fix copy mediapipe to a wrong directory

Open hiwei93 opened this issue 2 years ago • 4 comments
trafficstars

In npm strat script command, there is an error: copying scripts in third_party/mediapipe/ to a wrong directory ./src/apis/

In file src/apis/mediapipe_audio_blendshapes.ts, importing createMediaPipeLib from path ./mediapipe/web/graph_runner/graph_runner, so yarn start or npm start will be failed.

Fix this issue by copying scripts in third_party/mediapipe/ to the directory ./src/apis/mediapipe/

hiwei93 avatar May 28 '23 16:05 hiwei93

I think this is related to the talking_character demo app, so adding Jay & Yiling.

markmcd avatar May 29 '23 06:05 markmcd

I accidentally added a new commit to this pull request. And I don't know how to cancel it. 😂

I am not sure if it's ok to merge those two commits in one pull request.

hiwei93 avatar May 29 '23 11:05 hiwei93

I accidentally added a new commit to this pull request. And I don't know how to cancel it. joy

You can force push a branch/PR. You should be able to do something like git reset --hard HEAD^ (from the checked-out branch) to delete the last commit, then git push --force to update the PR.

Beware though, I have not tested these commands, so take a backup :)

markmcd avatar May 30 '23 06:05 markmcd

I accidentally added a new commit to this pull request. And I don't know how to cancel it. joy

You can force push a branch/PR. You should be able to do something like git reset --hard HEAD^ (from the checked-out branch) to delete the last commit, then git push --force to update the PR.

Beware though, I have not tested these commands, so take a backup :)

Thanks, I change it back. 🤝

hiwei93 avatar May 30 '23 13:05 hiwei93