flogger icon indicating copy to clipboard operation
flogger copied to clipboard

Add Maven coordinates to README.md

Open elharo opened this issue 7 years ago • 5 comments

elharo avatar Nov 08 '18 21:11 elharo

@ronshapiro would you be up for this (since I'm a Maven noob).

hagbard avatar Nov 22 '18 15:11 hagbard

Does this solve the issue? https://github.com/google/flogger/pull/57

clehene avatar Dec 10 '18 17:12 clehene

We have this already: https://github.com/google/flogger#1-add-the-dependencies-on-flogger

Were you asking for something else?

ronshapiro avatar Dec 10 '18 18:12 ronshapiro

Yes, those aren't in the correct format for Maven and are easy to miss. What most projects do is something like

To add a dependency on Guava using Maven, use the following:

<dependency>
  <groupId>com.google.guava</groupId>
  <artifactId>guava</artifactId>
  <version>27.0.1-jre</version>\
</dependency>

To add a dependency using Gradle:

dependencies {
  compile 'com.google.guava:guava:27.0.1-jre'
}

elharo avatar Dec 10 '18 18:12 elharo

I agree with @elharo. It's a matter of usability mostly. The actual example can be generated as well (although besides to scope / point of this)

clehene avatar Dec 13 '18 16:12 clehene