fhir-data-pipes
fhir-data-pipes copied to clipboard
Delete resources in the sink DB and FHIR server
Description of what I changed
Fixes #588 Delete the FHIR resources in the Sink DB and Sink FHIR servers during export.
E2E test
Relied on e2e tests.
TESTED:
Manually tested by deleting the resources from the source FHIR server and verifying the same from the sink systems.
Checklist: I completed these to help reviewers :)
-
[x] I have read and will follow the review process.
-
[x] I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
-
[x] My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
-
[x] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
-
[x] I ran
mvn clean packageright before creating this pull request and added all formatting changes to my commit. -
[x] All new and existing tests passed.
-
[x] My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master
Codecov Report
Attention: Patch coverage is 32.00000% with 17 lines in your changes missing coverage. Please review.
Project coverage is 51.43%. Comparing base (
062cc3d) to head (b1f8ddf).
Additional details and impacted files
@@ Coverage Diff @@
## master #1183 +/- ##
============================================
+ Coverage 51.34% 51.43% +0.08%
- Complexity 711 715 +4
============================================
Files 95 95
Lines 5886 5907 +21
Branches 781 787 +6
============================================
+ Hits 3022 3038 +16
- Misses 2578 2581 +3
- Partials 286 288 +2
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@bashir2 Sorry for the delay in addressing the review comments. Please have a look at my recent changes.