fhir-data-pipes
fhir-data-pipes copied to clipboard
Migrate FhirStoreUtilTest to Junit5
Description of what I changed
Fixes #1103
E2E test
TESTED:
Please replace this with a description of how you tested your PR beyond the automated e2e/unit tests.
Checklist: I completed these to help reviewers :)
-
[x] I have read and will follow the review process.
-
[x] I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
-
[x] My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
-
[x] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
-
[x] I ran
mvn clean packageright before creating this pull request and added all formatting changes to my commit. -
[x] All new and existing tests passed.
-
[x] My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master
This PR solve some of the test cases based on the Issue #1103
@chandrashekar-s
cc @bashir2
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 51.67%. Comparing base (
b03c2c7) to head (b209ce2).
Additional details and impacted files
@@ Coverage Diff @@
## master #1135 +/- ##
============================================
- Coverage 51.76% 51.67% -0.09%
+ Complexity 669 668 -1
============================================
Files 95 95
Lines 5612 5612
Branches 731 731
============================================
- Hits 2905 2900 -5
- Misses 2425 2430 +5
Partials 282 282
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@chandrashekar-s can you please review this PR
Hi @meetmehta1198 for the changes, there is an build error which you can see from the logs. Can you please have a look at it.
Hi @meetmehta1198, just a reminder to look into the build issue. Please let me know if you face any issues while accessing the build logs.
I will take a look into it! Thanks
@chandrashekar-s I have updated the code and the build is successful. Can you please approve this PR?
Thanks @chandrashekar-s for all the feedback and approval. Great experience working with you!
Only those with write access to this repository can merge pull requests.
I do not have necessary permissions to merge code!
Thanks @meetmehta1198 for this and congratulations on your first contribution to this repo. Just one minor comment: It seems to me that from #1103 you are fixing tests under the common module only, correct? Then I guess we should change the PR description as it currently says it fixes that bug (and will close that bug upon merge).
Thanks @meetmehta1198 for this and congratulations on your first contribution to this repo. Just one minor comment: It seems to me that from #1103 you are fixing tests under the
commonmodule only, correct? Then I guess we should change the PR description as it currently says it fixes that bug (and will close that bug upon merge).
I have updated the PR description, so that it does not close the main issue.