data-transfer-project icon indicating copy to clipboard operation
data-transfer-project copied to clipboard

Switch to using a padded AES encryption transformation

Open seehamrun opened this issue 4 years ago • 7 comments

This should fix #934

Note: ideally this would be tracked with a unit test, I'll work on adding that with this PR

seehamrun avatar Feb 02 '21 22:02 seehamrun

This pull request introduces 2 alerts when merging 0bf8b3988081d6159ee0149ddf355fab7f5fb179 into 653e6791fe4ba863d932a206a0f02f3173c001c7 - view on LGTM.com

new alerts:

  • 2 for Use of a broken or risky cryptographic algorithm

lgtm-com[bot] avatar Feb 02 '21 22:02 lgtm-com[bot]

Clsoing out this PR since there are a couple of things we need to fix first, it looks like the decryption is also a bit wonky and is trimming out some of the data

seehamrun avatar Feb 04 '21 15:02 seehamrun

This PR should be valid again now that #964 fixes the trimming problem.

philipsharp avatar Feb 26 '21 19:02 philipsharp

Reopening this PR -- after stronger consideration this path is only used in the local demo UI that we have built out for testing purposes so the warning is OK

seehamrun avatar Apr 05 '21 16:04 seehamrun

This pull request introduces 2 alerts when merging 8f28ef3e6490429b311ae6809ff80dccf5bbd466 into 889f1fa92fc54046b42a9448b53d9de0df84912c - view on LGTM.com

new alerts:

  • 2 for Use of a broken or risky cryptographic algorithm

lgtm-com[bot] avatar Apr 19 '21 18:04 lgtm-com[bot]

This pull request introduces 2 alerts when merging a892e792c105ab182b15fbe06e9b2eb457ebbea8 into 575776fcaf93c52973154433bcfe865df183574a - view on LGTM.com

new alerts:

  • 2 for Use of a broken or risky cryptographic algorithm

lgtm-com[bot] avatar May 25 '21 17:05 lgtm-com[bot]