data-transfer-project icon indicating copy to clipboard operation
data-transfer-project copied to clipboard

Remove check for `authPublicKey` when claiming jobs

Open calumcalder opened this issue 1 year ago • 2 comments
trafficstars

This check was originally added in 9d5302c, where it was used to check that two workers didn't attempt to claim the same job. Since then the surrounding code has seen a lot of refactoring, including migrating to calling claimJob on the job store which, per the comment in JobPollingService and on the JobStore interface docs, should do the job of ensuring this doesn't happen.

Removing this line unblocks the option of allowing workers to reclaim jobs from another crashed worker that couldn't inform the job store it was exiting (e.g. OOM killed), but also continues to allow blocking claimJob on claimed jobs by delegating that decision to the JobStore.

calumcalder avatar Aug 16 '24 14:08 calumcalder

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 16 '24 14:08 CLAassistant

Thanks for the review! Just waiting on legal to review the new CLA after the switch to DTI ownership

calumcalder avatar Aug 20 '24 15:08 calumcalder

CLA signed 👍

calumcalder avatar Sep 05 '24 16:09 calumcalder