The install target fails to install some headers

[yurivict]

These headers are installed by the FreeBSD port manually:

Error: Missing: include/cpu_features/cpuinfo_aarch64.h
Error: Missing: include/cpu_features/cpuinfo_arm.h
Error: Missing: include/cpu_features/cpuinfo_mips.h
Error: Missing: include/cpu_features/cpuinfo_ppc.h
Error: Missing: include/cpu_features/internal/hwcaps.h

Should they be installed by the project?

Version: 0.7.0 FreeBSD 13.1

[toor1245]

@Mizux

[Mizux]

1. Our install should only install header files of the target aka aarch64 headers won't be installed for a x86_64 build.

2. This cmake install rule define the headers install destination... https://github.com/google/cpu_features/blob/4590768e530a470a8fb8917dafee69932831c854/CMakeLists.txt#L230-L232

3. I'm not sure we "flag" our headers as PUBLIC_HEADER, so it is possible that none of our headers (even the required one in 1)) are installed, on my way to test and fix it if needed... EDIT: seems to work as expected... https://github.com/google/cpu_features/blob/4590768e530a470a8fb8917dafee69932831c854/CMakeLists.txt#L143 https://github.com/google/cpu_features/blob/4590768e530a470a8fb8917dafee69932831c854/CMakeLists.txt#L137 https://github.com/google/cpu_features/blob/4590768e530a470a8fb8917dafee69932831c854/CMakeLists.txt#L71-L95

@yurivict I would say these headers are unneeded and should be removed from the FreeBSD recipe or you need to flag them for install according to the target machine targeted i.e. Try to see if your FreeBSD pkg build recipe have conditional install rule according to the targeted CPU arch...

[ghost]

Hello sir , I am new to open source contribution. I already know java , my tech stacks & tools includes C, C++ , Python , Java, JavaScript , HTML , CSS , SQL , Bootstrap, ReactJS, ExpressJS, NodeJS & Git . I need a little help from your side to contribute to these amazing projects.