comprehensive-rust
comprehensive-rust copied to clipboard
google
zh-CN: translation for src/basic-syntax/string-slices.md
Hi @NoahDragon, could you please sign the CLA in https://github.com/google/comprehensive-rust/pull/767/checks?check_run_id=14172885371? This pr cannot be merged now.
Hi @NoahDragon, could you please sign the CLA in https://github.com/google/comprehensive-rust/pull/767/checks?check_run_id=14172885371? This pr cannot be merged now.
@NoahDragon is actually a Googler (indirectly visible on the profile because of the membership in the "Googlers" GitHub organization). So the CLA is fine — the underlying problem is that the suggestions were committed using a private address. This has happened a few times and we don't have a super good solution. The easiest solution is to squash out the Co-authored-by: line from the commit message.
@NoahDragon, you should be able to make your @google.com address the default for new GitHub-authored commits.
@wnghl Sorry for the late reply and oversight using my private email address in PR suggestions. I have updated my work email address, but there is no way to revert the existing commits.
As mgeisler suggested, it would be easy to remove the co-auther email to pass the CLA check. Could you please go through the steps to remove the co-author line in each commit message?
Didn't realize this PR could be edited by maintainers, resolved the issue and will wait the tests to pass.
Didn't realize this PR could be edited by maintainers, resolved the issue and will wait the tests to pass.
Thanks @NoahDragon! Most PRs can be edited like this (unless people explicitly uncheck the box when creating the PR). It has saved me from a lot of round-trips since I can freely fix small things without having to wait for the PR author :smile: