comprehensive-rust
comprehensive-rust copied to clipboard
Disambiguate b in main_improved.rs
When reading lines 43/44/47, I wonder how the b from line 43 can be matched against a b in line 44 and also again in 47. Without the syntax highlighting in the HTML code viewer, it is difficult to read the byte-string prefix as something different from the captured local b variable. I propose to rename the b variable to byte.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
Hi @LukasHanel, if you sign the CLA, then we can get this merged!
Hi @mgeisler , can you reuse the CLA from my colleague Alexandre Gonzalo? https://github.com/google/android-key-attestation/pull/9/checks
Hi @mgeisler , can you reuse the CLA from my colleague Alexandre Gonzalo?
I don't think there is any provision for reusing CLAs from other people like this — it's a simple bot and it only knows how to check your email address against a list of approved addresses.
Perhaps you can check with your colleguage about how to get approval to sign the CLA? That would make things easier for you in the future since you can contribute to all Google projects after signing it.
Hi @LukasHanel were you able to check whether you are able to sign the CLA? Thanks!
Replaced by #977.