comprehensive-rust icon indicating copy to clipboard operation
comprehensive-rust copied to clipboard

pl: Add mostly-machine-translated Polish translation

Open pierd opened this issue 2 years ago • 8 comments

Partial Polish translation

https://github.com/google/comprehensive-rust/issues/399

pierd avatar May 25 '23 19:05 pierd

Thanks a lot @pierd! I've reached out to people in Google to find someone who can skim through the translation here.

I know from translating into Danish that there are a lot of paragraphs where I wasn't sure about the best translation. If that was the case here too, then I hope you can work with the reviewer to find a good solution :smile:

To the reviewer: you can download the rendered course from the bottom of the test run.

mgeisler avatar May 26 '23 07:05 mgeisler

No worries. Please note that this is a work in progress, as far as I remember I finished chapters 1-10 (assuming nothing changed in the original text since March).

I'm happy to iterate here to bring it to a state where full chapters/sections/days are done so it's easy for others to contribute too.

pierd avatar May 26 '23 07:05 pierd

assuming nothing changed in the original text since March

I'm afraid there has been a bunch of typo fixes since then -- but you'll see that when you run msgmerge with an updated messages.pot file. A bunch of the translations will then be marked as fuzzy since the English original has changed. Fixing those should be fairly easy since the Polish translation presumably didn't copy the typos :smile:

mgeisler avatar May 26 '23 08:05 mgeisler

@jkotur, here is the PR we talked about.

mgeisler avatar May 26 '23 09:05 mgeisler

Thanks for the comments everyone! ❤️

@pawelpaa - I think something is broken on GitHub UI because a bunch of your comments are attached to a single line, I've applied some of them where I could find the problem from the context but for a few I'm not sure what they refer to

@jkotur - I've committed some of your suggestions through the web interface which means you are now listed as a co-author (congrats 😉), unfortunately this triggers GitHub action for CLA check. @mgeisler does it mean that @jkotur will have to sign the agreement?

pierd avatar Jun 01 '23 08:06 pierd

unfortunately this triggers GitHub action for CLA check. @mgeisler does it mean that @jkotur will have to sign the agreement?

Hmm... yeah, I see... there is a mixup of email addresses here. @jkotur is a Googlers so it should be fine, but the personal email address confused the system. I can probably fix it somehow, I'll take a look :smile:

mgeisler avatar Jun 01 '23 08:06 mgeisler

Sorry for the delay, I'm back now and I'll continue the review.

@pierd - can you squash my personal email out of this PR? Unless it's easy to replace it with my corp address. I've changed my default email so from now on CLA check should be fine with my suggestions.

jkotur avatar Jun 16 '23 13:06 jkotur

Squashed to clean co-authors (for the CLA check)

pierd avatar Jun 21 '23 15:06 pierd

Thanks a lot, @pierd!

mgeisler avatar Jun 22 '23 08:06 mgeisler