comprehensive-rust icon indicating copy to clipboard operation
comprehensive-rust copied to clipboard

Fix some broken fragment ID encodings in rustdoc links

Open eepeep opened this issue 2 years ago • 1 comments

I'm not exactly sure why they aren't decoded and considered equivalent, but the links were not working as-is for me in Chrome.

eepeep avatar Apr 20 '23 21:04 eepeep

Thanks for the PR!

I feel I've fixed this before... or at least changed the percent encoding here before. I'll have to try and figure out what's going on and why some people see broken links here.

mgeisler avatar Apr 21 '23 01:04 mgeisler

Hi @djmitche, this is similar to your #917 — did you find out why the links changed in your PR?

mgeisler avatar Jul 12 '23 09:07 mgeisler

Probably the lesson here is that we shouldn't be deep-linking to rust docs!

djmitche avatar Jul 12 '23 14:07 djmitche

I rebased the commit and this should merge after the tests are done.

mgeisler avatar Jul 14 '23 08:07 mgeisler