comprehensive-rust icon indicating copy to clipboard operation
comprehensive-rust copied to clipboard

Published 20 hours ago • verified publisher icon google

Add dprint to install-tools task.

Open egithinji opened this issue 3 months ago • 5 comments

As mentioned in CONTRIBUTING.md, dprint is used for formatting in the project. This PR adds dprint to the list of packages that are installed when one runs cargo xtask install-tools.

egithinji avatar Aug 13 '25 17:08 egithinji

I suspect the build failures were some sort of intermittent? I can't merge without them passing, but if necessary someone with admin privileges can.

djmitche avatar Aug 15 '25 23:08 djmitche

I suspect the build failures were some sort of intermittent? I can't merge without them passing, but if necessary someone with admin privileges can.

Not sure but might be related to https://github.com/rust-lang/rust/issues/143835. So as not to break the CI might be better if it's resolved first. I'll keep an eye on it and dig deeper when I get a chance.

egithinji avatar Aug 18 '25 06:08 egithinji

Once https://github.com/dprint/dprint/pull/1021 lands, we can upgrade our dprint version and I believe this should fix the build issues.

egithinji avatar Aug 27 '25 06:08 egithinji

Once dprint/dprint#1021 lands, we can upgrade our dprint version and I believe this should fix the build issues.

The PR is merged, but I didn't check if there is a new release yet.

mgeisler avatar Sep 20 '25 15:09 mgeisler

@egithinji I just checked there is a new release https://github.com/dprint/dprint/releases/tag/0.50.2 with that PR included

michael-kerscher avatar Oct 30 '25 09:10 michael-kerscher