comprehensive-rust icon indicating copy to clipboard operation
comprehensive-rust copied to clipboard

Correcting a little error on pt-BR.po

Open Gabriel-Sousa-Amorim opened this issue 5 months ago • 5 comments

Hello Everyone! Correcting little error, that do not translate to Brazilian Portuguese in po/pt-BR.po, adding a sentence in the end of the string for correct translation...

--- msgid "This segment should take about 15 minutes"
--- msgstr "Este segmento deve durar cerca de 15 minutos"

+++ msgid "This segment should take about 15 minutes. It contains:"
+++ msgstr "Este segmento deve durar cerca de 15 minutos. E possui:"

The correction is related with the following issue:

https://github.com/google/comprehensive-rust/issues/2777

Gabriel-Sousa-Amorim avatar Jun 18 '25 13:06 Gabriel-Sousa-Amorim

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jun 18 '25 13:06 google-cla[bot]

Hello, I added more corrections for translating all remaining similar messages that were not translated yet.

Gabriel-Sousa-Amorim avatar Jun 18 '25 14:06 Gabriel-Sousa-Amorim

The CI suggests looking at https://github.com/google/comprehensive-rust/blob/main/TRANSLATIONS.md#creating-and-updating-translations -- I think there's a bit more to do here?

djmitche avatar Jun 19 '25 16:06 djmitche

@Gabriel-Sousa-Amorim We appreciate your contribution, but the moment it is not possible to merge this PR. Please take a look at the logs of the failing checks and the instructions provided by @djmitche above.

gribozavr avatar Jul 28 '25 02:07 gribozavr

Hey @Gabriel-Sousa-Amorim, the check that prevents this PR from being merged is a bit... terse! But let me explain: it simply requires you to update the pt-BR.po file using Refreshing an Existing Translation.

This means that you must

  • Install the project tools: cargo xtask install-tools (you probably already did this)
  • Build the book: mdbook build (I guess you did this too)
  • Merge the fresh book/xgettext/messages.pot file into po/pt-BR.po (you did not do this)

This is all: you will know that you've done it correctly when you see the POT-Creation-Date header change. It's currently set to

"POT-Creation-Date: 2024-07-09T12:20:23-07:00\n"

The CI script simply checks that this line changes when any of the msgid fields change (to ensure you build a valid and consistent .po file).

mgeisler avatar Sep 01 '25 20:09 mgeisler