comprehensive-rust icon indicating copy to clipboard operation
comprehensive-rust copied to clipboard

Published 20 hours ago • verified publisher icon google

Rename LICENSE.txt to LICENSE

Open CodeMaster7000 opened this issue 2 years ago • 3 comments

The file should be named LICENSE per https://github.com/google/new-project.

CodeMaster7000 avatar Jan 20 '23 18:01 CodeMaster7000

Hey @CodeMaster7000,

Thanks, you're right that the file should be named LICENSE — I see that https://github.com/google/new-project uses that name too.

Can you update https://github.com/google/comprehensive-rust/blob/main/src/credits.md too?

mgeisler avatar Jan 24 '23 09:01 mgeisler

I have made the changes that you requested @mgeisler. Since the head repository has been deleted, I can no longer go back and make changes to this PR. However, #272 has the requested changes so both PRs should be ready to be merged.

CodeMaster7000 avatar Jan 24 '23 16:01 CodeMaster7000

Since the head repository has been deleted, I can no longer go back and make changes to this PR. However, #272 has the requested changes so both PRs should be ready to be merged.

Thanks for fixing the credits page.

I believe this PR still removes the line at the top of LICENSE? Since the repository was deleted, I suggest we close both PRs and you can then open a new single PR which does both changes in one commit (you'll need to clone it down on your own machine for this).

mgeisler avatar Jan 26 '23 18:01 mgeisler

@mgeisler Refer to #293 for the updated PR that reflects both of those requirements. I have also closed these 2 PRs. Thank you for the feedback!

CodeMaster7000 avatar Jan 27 '23 18:01 CodeMaster7000