comprehensive-rust icon indicating copy to clipboard operation
comprehensive-rust copied to clipboard

Published 20 hours ago • verified publisher icon google

Detect deletion of slides

Open Gourav2609 opened this issue 2 years ago • 6 comments

closes issue #1417

Gourav2609 avatar Oct 25 '23 19:10 Gourav2609

any suggestions🙂 ?

Gourav2609 avatar Oct 25 '23 19:10 Gourav2609

Oh, and please update the title of the PR to reflect what it does.

djmitche avatar Oct 25 '23 19:10 djmitche

sry @djmitche for late reply ... will soon come up with changes

Gourav2609 avatar Oct 29 '23 12:10 Gourav2609

Hi @Gourav2609, thanks for looking at this issue!

As a high-level comment, I would like code such as this to be written in Python. See https://github.com/google/comprehensive-rust/blob/main/.github/workflows/check-msgid-changes.yml which calls directly out to https://github.com/google/comprehensive-rust/blob/main/.github/workflows/check-msgid-changes.py.

We cannot maintain large amounts of Bash code, so that is why I think we should write this in a high-level language instead.

mgeisler avatar Nov 16 '23 13:11 mgeisler

@Gourav2609 are you able to continue working on this?

djmitche avatar Jan 29 '24 17:01 djmitche

@djmitche sry.. Got a little busy with college hackathon.. Will soon start working on it

Gourav2609 avatar Jan 31 '24 11:01 Gourav2609