automotive-design-compose
automotive-design-compose copied to clipboard
google
Fix #1503: ensure child composables are drawn, by using Layout ID rather than SquooshResolvedNode identity.
The previous check (that the SquooshResolvedNodes were equal) failed, because during a transition we generate a new set of SquooshResolvedNodes from the source tree and dest tree. With this change, we consult the layout ID, which is unique within a tree (so still useful for this purpose of identifying the selected node for child rendering).
@rylin8 PTAL - I want to add tests to this; sharing now because I needed it to make a demo work.
Snapshot diff report vs base branch: main Last updated: Mon Aug 12 01:48:58 PDT 2024, Sha: 8fe1ada07e8a6bafb2e8bb55e662385732d2d032 No differences detected
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
So replacement content, components, and nodes with interactions don't render with animations?
So replacement content, components, and nodes with interactions don't render with animations?
Interactions work fine during animation, because those are all Composables that never draw anything at all. Replacement content that draws content (i.e.: all of it) was getting hidden during animations.
LGTM. Let me know if you plan on adding tests to this PR or separately -- or if you'd like me to.
@rylin8 thanks - I'd really appreciate it if you could add a test for this part of animation.