automotive-design-compose icon indicating copy to clipboard operation
automotive-design-compose copied to clipboard

Impossible to fetch node under intersection/union

Open elouannf opened this issue 2 years ago • 11 comments

I tried to reach a node which is used under an intersection in figma. When I tried to fetch it through DesignCompose i couldn't access to it. For example i used the element Modifier and I couln't modifiy my element. Here is a example : image

elouannf avatar Jun 23 '23 13:06 elouannf

Yes, confirming that this is an issue -- children of unions/intersections are always treated as vectors, so the fact that there's a text node is lost. Let's keep this issue to fix customization inside of a union/intersection.

@elouannf we're adding support for mask layers in (https://github.com/google/automotive-design-compose/pull/85)[this change], which will be in the next release (0.21). Would masking let you achieve the effect as a work around?

iamralpht avatar Jun 23 '23 20:06 iamralpht

If masks are added I can use them instead of intersection. If I can modify the mask thanks to a gauge/ modifier / text element and acess to nodes inside the mask, the Design should work properly. Thank you for the support can wait to try it out !

elouannf avatar Jun 24 '23 10:06 elouannf

@elouannf we're planning on cutting the RC for 0.21 tomorrow, so you should be able to try that out next week. Alternatively since mask layer support merged into main, you can also checkout main and build everything from source to get an earlier look at the functionality.

iamralpht avatar Jun 29 '23 18:06 iamralpht

@timothyfroehlich please comment once RC is available

iamralpht avatar Jun 29 '23 18:06 iamralpht

moving to iteration 0.22 so we keep track of the ticket

iamralpht avatar Jul 05 '23 20:07 iamralpht

Leaving for vacation distracted me from updating this ticket. RC's for 0.21.0 are available now, and we're wrapping up the full release of 0.21.0 now, which will be available via Maven by the end of the day.

timothyfroehlich avatar Jul 14 '23 16:07 timothyfroehlich

Hi we tried the new release and we found that there is still some trouble with masks ( for instance using Vectors as a mask). are there other limitations ?

elouannf avatar Jul 18 '23 12:07 elouannf

Vectors as a mask should be supported. Could you provide an example of a mask setup that isn't working for you? Here are a couple screenshots of masks that we use in our test: Screenshot 2023-07-18 at 8 31 49 AM Screenshot 2023-07-18 at 8 33 15 AM

rylin8 avatar Jul 18 '23 15:07 rylin8

@elouannf friendly ping on this -- do you have a mask example you can share that isn't working?

iamralpht avatar Aug 09 '23 20:08 iamralpht

Hi Ralph, sorry for the delay I just found the problem for our masks. It's not a big deal because I was able to make it work in another way. But here is the hierarchy that is currently working on figma but not on on DesignCompose it's not very important because I was able to make these changes anyway : image also this one is working in both : image

elouannf avatar Aug 14 '23 11:08 elouannf

Untitled.zip Hi Ralph , Here is an example. Even if there is an easier way to create this animation at first and it didn't worked. I tried to animate using your dial and gauge plugin.

elouannf avatar Aug 17 '23 14:08 elouannf