android-fhir icon indicating copy to clipboard operation
android-fhir copied to clipboard

Date Picker Constraint Issue Fix.

Open AdityaKBhadragond14 opened this issue 1 year ago • 5 comments

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2508

Description The MaterialDatePicker Builder has been modified such that if the questionnaire item has the minimum date extension added then the MaterialDatePicker.setSelection() will have that minimum date from extension else it will get the local date. This way it will select the first valid date based on the constraints added for date.

Alternative(s) considered Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type Bug Fix

Screenshots (if applicable)

Checklist

  • [x] I have read and acknowledged the Code of conduct.
  • [x] I have read the Contributing page.
  • [x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • [x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • [x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • [x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • [x] I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

AdityaKBhadragond14 avatar Apr 18 '24 05:04 AdityaKBhadragond14

Thanks Aditya for this PR. Can you address the comments ?

I have addressed the comments. Please do a re-review. Thanks.

AdityaKBhadragond14 avatar Apr 30 '24 07:04 AdityaKBhadragond14

Hi @AdityaKBhadragond14

It seems the build is failing on few tests in QuestionnaireUiEspressoTest. It's not available via kokoro logs here and we are working on it via this ticket Issue/2515.

In the meantime these are the errors:- Screenshot 2024-06-03 at 6 11 16 PM

This should be an easy fix. Requesting you to fix these and upload a commit. It will automatically merge the PR. Thanks and apologies for the late response on this.

MJ1998 avatar Jun 03 '24 12:06 MJ1998

Hi @AdityaKBhadragond14

It seems the build is failing on few tests in QuestionnaireUiEspressoTest. It's not available via kokoro logs here and we are working on it via this ticket Issue/2515.

In the meantime these are the errors:- Screenshot 2024-06-03 at 6 11 16 PM

This should be an easy fix. Requesting you to fix these and upload a commit. It will automatically merge the PR. Thanks and apologies for the late response on this.

Sure @MJ1998 . I will do it. Thanks.

AdityaKBhadragond14 avatar Jun 04 '24 04:06 AdityaKBhadragond14

@jingtang10 I have made the changes please have a look. Thanks.

AdityaKBhadragond14 avatar Jun 06 '24 12:06 AdityaKBhadragond14

Ohh I am sorry, I misunderstood it. You mean the existing answer will come from the Questionnaire? @jingtang10

AdityaKBhadragond14 avatar Jun 06 '24 13:06 AdityaKBhadragond14