adk-python icon indicating copy to clipboard operation
adk-python copied to clipboard

fix: expose LlmRequest & LlmResponse via __all__ in models/__init__.py

Open ksachdeva opened this issue 1 week ago • 4 comments

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

  • Closes: #issue_number
  • Related: #issue_number

2. Or, if no issue exists, describe the change:

This changes exposes LlmRequest & LlmResponse types adk.models submodule

Problem: In the models/init.py, LlmRequest & LlmResponse were imported with the intention to expose but were not included in the all. In any case, these types are frequently used by applications hence exposing makes code cleaner.

Solution: these types are frequently used by applications hence exposing makes them makes app code cleaner.

Testing Plan

Please describe the tests that you ran to verify your changes. This is required for all PRs that are not small documentation or typo fixes.

Unit Tests:

  • [ ] I have added or updated unit tests for my change.
  • [ ] All unit tests pass locally.

Please include a summary of passed pytest results.

Manual End-to-End (E2E) Tests:

Please provide instructions on how to manually test your changes, including any necessary setup or configuration. Please provide logs or screenshots to help reviewers better understand the fix.

Checklist

  • [x] I have read the CONTRIBUTING.md document.
  • [x] I have performed a self-review of my own code.
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [ ] New and existing unit tests pass locally with my changes.
  • [x] I have manually tested my changes end-to-end.
  • [ ] Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

ksachdeva avatar Nov 26 '25 16:11 ksachdeva

Summary of Changes

Hello @ksachdeva, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the LlmRequest and LlmResponse types were not properly exposed in the adk.models submodule, despite being imported. By including them in the __all__ list, applications can now directly import these frequently used types, which simplifies code and improves maintainability.

Highlights

  • Module Exposure: The LlmRequest and LlmResponse types are now explicitly exposed through the __all__ variable in src/google/adk/models/__init__.py, making them directly accessible from the adk.models submodule.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Nov 26 '25 16:11 gemini-code-assist[bot]

Response from ADK Triaging Agent

Hello @ksachdeva, thank you for creating this PR!

Could you please provide a testing plan for your change? This will help reviewers to review your PR more efficiently. Thanks!

adk-bot avatar Nov 26 '25 16:11 adk-bot

Hi @ksachdeva , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Your PR has been received by the team and is currently under review. We will provide feedback as soon as we have an update to share.

ryanaiagent avatar Nov 30 '25 05:11 ryanaiagent

Hi @wyf7107 , can you please review this.

ryanaiagent avatar Nov 30 '25 05:11 ryanaiagent