adk-go icon indicating copy to clipboard operation
adk-go copied to clipboard

fix(functiontool): recover from panics in user functions

Open unbiasedcodex opened this issue 4 days ago • 2 comments

Summary

  • Add panic recovery to functionTool.Run() to prevent agent crashes when user-provided functions panic
  • Panics are converted to errors with descriptive messages including the tool name
  • Add test case to verify panic recovery behavior

Resolves the TODO at tool/functiontool/function.go:135:

// TODO: Handle panic -> convert to error.

Test plan

- Added TestFunctionTool_PanicRecovery unit test
- Test creates a function that intentionally panics and verifies:
  - Error is returned (not nil)
  - Result is nil
  - Error message contains "panic in tool" and the tool name
- Ran locally: go test ./tool/functiontool/... -run TestFunctionTool_PanicRecovery -v → PASS

unbiasedcodex avatar Nov 27 '25 10:11 unbiasedcodex

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Nov 27 '25 10:11 google-cla[bot]

Summary of Changes

Hello @unbiasedcodex, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces robust error handling to the functionTool component by implementing a panic recovery mechanism. This change prevents agent crashes when user-defined functions unexpectedly panic, instead converting these panics into structured errors. This significantly improves the stability and resilience of the system when interacting with external or potentially unstable user code.

Highlights

  • Panic Recovery: Implemented a defer and recover mechanism within the functionTool.Run() method to catch panics that may occur in user-provided functions.
  • Error Conversion: Panics caught by the recovery mechanism are now converted into error types, including a descriptive message that specifies "panic in tool" and the name of the tool that panicked.
  • Test Coverage: A new unit test, TestFunctionTool_PanicRecovery, has been added to thoroughly verify that the panic recovery mechanism functions as expected, ensuring errors are returned and results are nil upon a panic.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Nov 27 '25 10:11 gemini-code-assist[bot]