adk-go
adk-go copied to clipboard
Add command-line params in web launcher for server timeouts
Summary of Changes
Hello @kdroste-google, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces enhanced flexibility for the web launcher by making server timeouts configurable. Previously, these timeouts were fixed, but now they can be dynamically set via new command-line parameters. This change allows for more granular control over the server's behavior, enabling administrators to fine-tune responsiveness and resource management according to specific operational requirements.
Highlights
- Configurable Server Timeouts: New fields (writeTimeout, readTimeout, idleTimeout) have been added to the
webConfigstruct to store server timeout durations, making these values configurable. - Dynamic Timeout Application: The
http.Serverconfiguration now utilizes the newly addedwebConfigfields forWriteTimeout,ReadTimeout, andIdleTimeout, replacing previously hardcoded values. - Command-Line Parameters: New command-line flags (
--write-timeout,--read-timeout,--idle-timeout) have been introduced, allowing users to specify server timeout values directly when launching the web server.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.