adk-go
adk-go copied to clipboard
fix: Refactor RunAgentRequest field names to snake_case
Updated the JSON tags in the RunAgentRequest struct to use snake_case for consistency with API conventions. Removed the AssertRunAgentRequestRequired method and related imports.
Fixes #255
Summary of Changes
Hello @tpryan, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on enhancing API consistency by refactoring the JSON field names within the RunAgentRequest struct to adhere to snake_case conventions. Concurrently, it cleans up the codebase by removing an obsolete validation method and its related import, contributing to a more standardized and maintainable API definition.
Highlights
- JSON Tag Refactoring: The JSON tags within the
RunAgentRequeststruct have been updated to usesnake_casefor improved API consistency, aligning with common conventions. - Code Cleanup: The
AssertRunAgentRequestRequiredmethod and its associatedfmtimport have been removed, streamlining the codebase by eliminating obsolete validation logic.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.
I removed AssertRunAgentRequestRequired because as far as I can tell it isn't called anywhere.
I'm afraid it would break ADK WebUI which is calling api/run_sse with payload like:
{"appName":"weather_time_agent","userId":"user","sessionId":"................","newMessage":{"role":"user","parts":[{"text":"London"}]},"streaming":false,"stateDelta":null}
Well then we need to decide which pattern to follow, and document because as it is, new devs can't use this feature.
What is the ADK API standard style? We need to be 100% compatible with the implementation in ADK Python.
What is the ADK API standard style? We need to be 100% compatible with the implementation in ADK Python.
This one https://github.com/google/adk-go/issues/255#issuecomment-3516317834
camelCase is the official ADK API style, see https://github.com/google/adk-go/issues/255#issuecomment-3529831091 for more details.