XNNPACK
XNNPACK copied to clipboard
Rename libraries to include 'xnnpack-' prefix to avoid conflict
try to fix https://github.com/google/XNNPACK/issues/8488
try to fix #8488
I think you will also need to update the CMakeLists.txt files in the bench/ and test/ subdirectories as well.
I'm wondering if the problem here is that we aren't making our libraries private or something? Maybe they should be in a subfolder? It seems like this kind of collision shouldn't be possible. Prefixing with xnnpack- should fix it of course, but I don't think we should need to.
I'm wondering if the problem here is that we aren't making our libraries private or something? Maybe they should be in a subfolder? It seems like this kind of collision shouldn't be possible. Prefixing with xnnpack- should fix it of course, but I don't think we should need to.
I am not sure if that is easy to fix. In my understanding it may require a refactor which takes quite efforts. I am not an expert of Cmake so I may be wrong, but as a user any solution is good to me as long as it works.
@gonnet please help to take a look again
I tried various things that seem like they should work, but CMake seems to foil anything that might be considered any kind of namespace. We should just do this renaming.