google
Support pinv
@alewis Hey I'm new to the project and would love to contribute. Given this seems like a good first issue, can you please provide the scope for this one ?
Sure, happy to have you. The goal would be to add the numpy function pinv https://numpy.org/doc/stable/reference/generated/numpy.linalg.pinv.html to the library via each of the various backends. The first step is to go to tensornetwork/backends/abstract_backend.py and to add it there, using the other existing functions as guides, and then to the tests in the same folder. Why don't you give that a shot and we'll sync up?
@alewis Thanks for the details. Seems fairly straightforward. I will get back to you once I'm done with the first one. Can you assign me the issue in the meantime ?
@alewis , Added a PR #850 for adding PINV to abstract_backend. Your feedback would be really appreciated! I shall also start working on adding it to the other backends and eventually the tensor, per your approval.
@alewis I have made the requested changes. In case you will be approving the #850 , shall I proceed to adding PINV to other backends ?
Hi. I'm new over here. If this issue is still open then can I add PINV to other backends? @alewis Also could you mention in which all backends should I add PINV?
That’d be great!
On Thu, Apr 1, 2021 at 8:51 AM Raunak Bhupal @.***> wrote:
Hi. I'm new over here. If this issue is still open then can I add PINV to other backends?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/google/TensorNetwork/issues/844#issuecomment-811885234, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAINHBUTOAS4U57RS2AJTGDTGRT5VANCNFSM4R5W7LBA .
Since I'm new and this is my first time Could you please direct me to which other backends shall I make those changes?
Hi @alewis, I am new to Open-source and would love to contribute. Please let me know which other backends do we need to add the PINV function
I believe it has only been added to the abstract backend (the base class). It needs to be added to all the other ones. Maybe you guys can divide the work?
@alewis I added a PR https://github.com/google/TensorNetwork/pull/935. I ran the pytests but am not sure how to run the workflow checks. Please suggest any improvements which can be made in this pr.
@alewis hi, is this issue still open? if, yes, may I work on this issue, since this issue was opened nearly 3 years ago?
