TensorNetwork icon indicating copy to clipboard operation
TensorNetwork copied to clipboard

fix all pytorch tests

Open mganahl opened this issue 5 years ago • 7 comments

As of lately pytorch has complex number support. This means we have to fix the tests that were skipping pytorch on the ground that complex was not supported.

mganahl avatar Jul 31 '20 21:07 mganahl

Oh that's very exciting!

chaserileyroberts avatar Jul 31 '20 22:07 chaserileyroberts

It seems that, while PyTorch does indeed have complex numbers now, many operations in practice choke on them. I'm still not totally sure of this though.

alewis avatar Aug 10 '20 02:08 alewis

It's still in beta I think. But my guess is that they'll further develop it. Quantum computing and classical simulation of circuits is growing more important, and I guess they want to stay competitive there as well.

mganahl avatar Aug 10 '20 14:08 mganahl

Could I take up this, for my first contribution ?

glitch401 avatar Oct 05 '20 16:10 glitch401

This actually might be fixed and we just forget to close it - @mganahl ?

alewis avatar Oct 05 '20 18:10 alewis

In the case that it is, #844 might be a good place to start? We'd be thrilled to have you!

alewis avatar Oct 05 '20 18:10 alewis

Are there any more fixes needed. I'm looking for first contribution.

Mahas1234 avatar Apr 22 '24 10:04 Mahas1234