reverse-engineering-neural-networks icon indicating copy to clipboard operation
reverse-engineering-neural-networks copied to clipboard

Published 20 hours ago • verified publisher icon google-research

Add tests for datasets.

Open nirum opened this issue 5 years ago • 2 comments

Especially to make sure that the index is less than the sequence length, as this causes issues due to jax's clamping behavior

nirum avatar Aug 19 '20 06:08 nirum

In addition, should we change the select in loss and accuracy to select index - 1? This would maintain consistency with the other datasets, where index is given as the length of the sentences.

ramasesh avatar Aug 19 '20 07:08 ramasesh

That might get confusing if one passes in index = 0 because then it would select the last element (-1)

nirum avatar Aug 19 '20 07:08 nirum