upload-cloud-storage icon indicating copy to clipboard operation
upload-cloud-storage copied to clipboard

Inconsistent path processing for `.gcloudignore`

Open eddielin0926 opened this issue 1 year ago • 2 comments

TL;DR

The issue pertains to inconsistent path processing when the given path is treated as the root directory, but the top-level .gcloudignore is utilized. Therefore, the path in .gcloudignore is concatenated with the given path variable.

Expected behavior

The paths listed in .gcloudignore should be calculated from the path of .gcloudignore.

Observed behavior

No response

Action YAML

- id: 'upload-file'
  uses: 'google-github-actions/upload-cloud-storage@v2'
  with:
    path: '/path/to/file'
    destination: 'bucket-name'
    process_gcloudignore: true

Log output

No response

Additional information

No response

eddielin0926 avatar Apr 15 '24 15:04 eddielin0926

How does gcloud behave here? I believe we mirrored the same functionality.

sethvargo avatar Apr 15 '24 18:04 sethvargo

How does gcloud behave here? I believe we mirrored the same functionality.

gcloud does not always use the top-level .gcloudignore. It uses the .gcloudignore located in the given directory.

Here is an example.

$ mkdir -p example/upload && cd example
$ echo "upload/a.txt" > .gcloudignore
$ echo "b.txt" > upload/.gcloudignore
$ touch upload/a.txt upload/b.txt
$ gcloud meta list-files-for-upload
.gcloudignore
upload/.gcloudignore
upload/b.txt
$ gcloud meta list-files-for-upload upload
.gcloudignore
a.txt

eddielin0926 avatar Apr 26 '24 19:04 eddielin0926