release-please-action icon indicating copy to clipboard operation
release-please-action copied to clipboard

docs(readme): Add `changelog-type`

Open wraithgar opened this issue 3 years ago • 5 comments

Adds changelog-type option to the readme.

wraithgar avatar Mar 08 '22 18:03 wraithgar

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

google-cla[bot] avatar Mar 08 '22 18:03 google-cla[bot]

It looks like this was removed in v3?

wraithgar avatar Mar 16 '22 21:03 wraithgar

@wraithgar I don't believe we intentionally removed this functionality in the parent release-please, but we should make sure it's supported before we document the config setting.

bcoe avatar Mar 20 '22 13:03 bcoe

@chingor13 happen to know if changelog-type is again supported?

bcoe avatar Apr 20 '22 15:04 bcoe

My observation is that this action gives a different meaning to changelog-type that in release-please itself. Therefore, to answer @bcoe's question, I do not think changelog-type is supported right now. Resolving this was my motivation for #474.

andrewesweet avatar May 03 '22 09:05 andrewesweet